X-Git-Url: http://www2.svjatoslav.eu/gitweb/?a=blobdiff_plain;f=src%2Fmain%2Fjava%2Feu%2Fsvjatoslav%2Fcommons%2Fcommandline%2Fparameterparser%2FParser.java;h=69b26dc9f7bfb71ee04078770da2fe5e2e29be13;hb=a8164358cbf6ceedabae88880078307b604db829;hp=bd4cb17ba86949eed4bdbf08c29e3e0aa45f62e1;hpb=ab4cc64cf105d4f03b8a0b94ab58d9b973820c8a;p=svjatoslav_commons.git

diff --git a/src/main/java/eu/svjatoslav/commons/commandline/parameterparser/Parser.java b/src/main/java/eu/svjatoslav/commons/commandline/parameterparser/Parser.java
index bd4cb17..69b26dc 100755
--- a/src/main/java/eu/svjatoslav/commons/commandline/parameterparser/Parser.java
+++ b/src/main/java/eu/svjatoslav/commons/commandline/parameterparser/Parser.java
@@ -11,13 +11,6 @@ package eu.svjatoslav.commons.commandline.parameterparser;
 
 import java.util.ArrayList;
 
-import eu.svjatoslav.commons.commandline.parameterparser.parameter.DirectoryParameter;
-import eu.svjatoslav.commons.commandline.parameterparser.parameter.FileParameter;
-import eu.svjatoslav.commons.commandline.parameterparser.parameter.IntegerParameter;
-import eu.svjatoslav.commons.commandline.parameterparser.parameter.NullParameter;
-import eu.svjatoslav.commons.commandline.parameterparser.parameter.StringParameter;
-import eu.svjatoslav.commons.commandline.parameterparser.parameter.StringParameters;
-
 /**
  * <pre>
  * Single commandline parameter can have any amount of arguments.
@@ -27,52 +20,32 @@ public class Parser {
 
 	private final ArrayList<Parameter> parameters = new ArrayList<Parameter>();
 
-	public void addParameter(final Parameter parameter) {
-		parameters.add(parameter);
-	}
-
-	public DirectoryParameter createDirectoryParameter(final String description) {
-		final DirectoryParameter parameter = new DirectoryParameter(description);
-		parameters.add(parameter);
-		return parameter;
-	}
-
-	public FileParameter createFileParameter(final String description) {
-		final FileParameter parameter = new FileParameter(description);
+	public <E extends Parameter> E add(final E parameter) {
 		parameters.add(parameter);
 		return parameter;
 	}
 
-	public IntegerParameter createIntegerParameter(final String description) {
-		final IntegerParameter parameter = new IntegerParameter(description);
-		parameters.add(parameter);
-		return parameter;
-	}
-
-	public NullParameter createNullParameter(final String description) {
-		final NullParameter parameter = new NullParameter(description);
-		parameters.add(parameter);
-		return parameter;
-	}
+	/**
+	 * @return <code>true</code> if no errors were found. <code>false</code>
+	 *         otherwise.
+	 */
+	private boolean checkMandatoryArgumentsPresent() {
 
-	public StringParameter createStringParameter(final String description) {
-		final StringParameter parameter = new StringParameter(description);
-		parameters.add(parameter);
-		return parameter;
-	}
+		for (final Parameter parameter : parameters)
+			if (parameter.isMandatory() && (!parameter.isParameterSpecified())) {
+				System.out.println("Error! Mandatory parameter ("
+						+ parameter.getAliases() + ") is not specified.");
+				return false;
+			}
 
-	public StringParameters createStringParameters(final String description) {
-		final StringParameters stingParameters = new StringParameters(
-				description);
-		parameters.add(stingParameters);
-		return stingParameters;
+		return true;
 	}
 
 	/**
 	 * Return parameter by given alias or <code>null</code> if no parameter
 	 * exists for given alias.
 	 */
-	public Parameter getParameterByAlias(final String alias) {
+	public Parameter findParameterByAlias(final String alias) {
 
 		for (final Parameter parameter : parameters)
 			if (parameter.matchesAlias(alias))
@@ -91,7 +64,7 @@ public class Parser {
 
 		for (final String argument : args) {
 
-			final Parameter parameterForAlias = getParameterByAlias(argument);
+			final Parameter parameterForAlias = findParameterByAlias(argument);
 			if (parameterForAlias == null) {
 				if (currentParameter == null) {
 					System.out.println("Unknown commandline parameter: "
@@ -113,16 +86,7 @@ public class Parser {
 
 		}
 
-		// check if any mandatory parameters are missing
-
-		for (final Parameter parameter : parameters)
-			if (parameter.isMandatory() && (!parameter.isParameterSpecified())) {
-				System.out.println("Error! Mandatory parameter ("
-						+ parameter.getAliases() + ") is not specified.");
-				return false;
-			}
-
-		return true;
+		return checkMandatoryArgumentsPresent();
 	}
 
 	public void showHelp() {